Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED drivers: change "TWI" to "I2C" #22617

Merged
merged 1 commit into from
Dec 6, 2023
Merged

LED drivers: change "TWI" to "I2C" #22617

merged 1 commit into from
Dec 6, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 5, 2023 •
edited
Loading

Description

Just a small nit, as these are basically the only places left where I2C is referred to as TWI. The comment above also makes reference to a function that no longer exists since the adoption of i2c_master.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 5, 2023 23:51
@drashna drashna merged commit b6fbed3 into qmk:develop Dec 6, 2023
3 of 4 checks passed
@fauxpark fauxpark deleted the led-drivers-twi-to-i2c branch December 6, 2023 04:52
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
LED drivers: change "TWI" to "I2C" (qmk#22617)
afd8d92
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
LED drivers: change "TWI" to "I2C" (qmk#22617)
103b582
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
LED drivers: change "TWI" to "I2C" (qmk#22617)
da4b0a9
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED drivers: change "TWI" to "I2C" (qmk#22617)
32d7fb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr